Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Consistently format imports... #113

Merged
merged 1 commit into from
Nov 14, 2024
Merged

chore: Consistently format imports... #113

merged 1 commit into from
Nov 14, 2024

Conversation

rklaehn
Copy link
Collaborator

@rklaehn rklaehn commented Nov 14, 2024

using

cargo fmt --all -- --config unstable_features=true --config imports_granularity=Crate,group_imports=StdExternalCrate,reorder_imports=true,format_code_in_doc_comments=true

using

cargo fmt --all -- --config unstable_features=true --config imports_granularity=Crate,group_imports=StdExternalCrate,reorder_imports=true,format_code_in_doc_comments=true
Copy link
Contributor

@flub flub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I guess you're a convert of formatting imports now ;)

I would recommend to also copy over the Makefile.toml from the iroh repo and also enforce this in CI now, otherwise you'll keep having to do this.

@rklaehn
Copy link
Collaborator Author

rklaehn commented Nov 14, 2024

Nice, I guess you're a convert of formatting imports now ;)

I would recommend to also copy over the Makefile.toml from the iroh repo and also enforce this in CI now, otherwise you'll keep having to do this.

I am a convert to this, but not yet a convert to having it done in CI. If I have to do this manually once every 6 months that's fine.

@rklaehn rklaehn merged commit 08750c5 into main Nov 14, 2024
14 of 15 checks passed
@rklaehn rklaehn deleted the fmtall branch November 14, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants