Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This PR makes a couple of changes with the goal to make this library compatible with an upcoming Rust implementation in RustCrypto: RustCrypto/password-hashes#232
There are really only two changes required that intend to bring the implementation closer to the research paper/prototype implementation:
ints_to_block
function, but otherwise doesn't go into detail what this is. The prototype implementation uses encryption to create a byte "block" of these values. I have decided to simply hash them with the selected hash. Alternatively it may be valuable to always use SHA-1 here as this part isn't really cryptographically important and it could avoid any increased cost by "slower" hashes.I'm open to any suggestions!