-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alert documentation is confusing #244
Comments
I’m also quite confused when reading the guide about popups. Why is |
Alerts and sheets look similar from the public APIs, both in swiftUI and in view inspector (at least, I aim to align the APIs), but under the hood, there are sometimes dramatic differences in inner structure and workings. Apple's engineers have revamped the implementation of Alerts several times (they usually don't do that with the other swiftui views), if you look at the code in the library you'll see all the branching based on the OS versions. I will double check the docs for actuality though, thanks for the heads up |
@nalexn thanks for the explanation. I wasn’t aware of that, since also the SwiftUI of |
The documentation at https://github.com/nalexn/ViewInspector/blob/master/guide_popups.md#alert is confusing. Specifically for alerts it states
If you're using alert functions added in iOS 15 (those not marked as deprecated) - you're good to go.
and then states that only if you are NOT using those functions you will need to add the shim code. However errors in unit tests direct back to the documentation even if the alert functions > iOS 15 are being used. I think this documentation could be clarified as to WHEN the shim code is needed and how a test should be written if the shim code is NOT needed.The text was updated successfully, but these errors were encountered: