Skip to content
This repository has been archived by the owner on Jul 14, 2020. It is now read-only.

Need help cleaning up the code #188

Open
gulbinas opened this issue Sep 10, 2014 · 0 comments
Open

Need help cleaning up the code #188

gulbinas opened this issue Sep 10, 2014 · 0 comments

Comments

@gulbinas
Copy link
Collaborator

At the moment we have passing tests on master branch.
Tests include pep and lint.
At the moment there is many disabled lint errors:

# R0201    Method could be a function
# C0111    No docstring
# W0511    TODO can be
# W0212    Access to a protected member  of a client class
# W0622    Redefining built-in 'id'
# R0924    Badly implemented Container, implements __getitem__ but not __delitem__, __len__, __setitem__
# C0103    Invalid name "CallableDocument" for type variable (should match [a-z_][a-z0-9_]{1,30}$)
# R0903    53,0:MongoKitConnection: Too few public methods (1/2)
# E1101    No member
# W0221    Arguments differ from overriden method
# W0401,W0614,W0611 wildcard/unused import
# R0912    74,4:DocumentProperties._validate_descriptors: Too many branches (23/12)
# R0902:138,0:Document: Too many instance attributes (9/7)
# R0913:161,4:Document.__init__: Too many arguments (6/5)
# W0142:465,12:Document.generate_index: Used * or ** magic
# E0611    No name 'OperationFailure' in module 'pymongo.connection'
# R0915:486,8:SchemaDocument._validate_structure.__validate_structure: Too many statements (61/50)
# R0914:571,4:SchemaDocument._validate_doc: Too many local variables (16/15)
# E1102:186,30:Document.__init__: self.migration_handler is not callable
# W0702:261,8:Document.get_size: No exception type(s) specified
# W0102:628,4:Document.__deepcopy__: Dangerous default value {} as argument
# W0201:630,8:Document.__deepcopy__: Attribute '__dict__' defined outside __init__
# W0703:664,27:SchemaDocument._process_validators: Catching too general exception Exception
# W1201:116,16:DotedDict.__setattr__: Specify string format arguments as logging function parameters

Disabled lint errors are configured in .pylintrc file

You can easily contribute by fixing those errors.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant