Port old conrod example "simple_ui" to egui #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay everything works except the position variable, the old example used an XYPad for this, but I can't really find anything comparable in egui. I could implement something like XYPad myself, but that would complicate the example and I'm not really sure if that's worth it considering the name of the example. |
There was a problem hiding this comment.
Thanks so much @jorikvanveen, looking good!
I've left a few small suggestions, if you could address these I'd be happy to land this :)
|
Okay I just committed everything (except the random color thing), LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add a new example:
examples/ui/egui/simple_ui.rs, it's the egui version of an old example found here: https://github.com/nannou-org/nannou_conrod/blob/main/examples/simple_ui.rs. As requested in #856.I'm relatively new to nannou and this is my first contribution so don't be afraid to tell me how I can do better!
Closes #856