Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge dev to master #385

Open
vhaasteren opened this issue May 7, 2024 · 5 comments
Open

Merge dev to master #385

vhaasteren opened this issue May 7, 2024 · 5 comments

Comments

@vhaasteren
Copy link
Member

vhaasteren commented May 7, 2024

Let's merge dev into master and do a new Enterprise release. @AaronDJohnson, @vallis, others, what would you like to get added/modified before then?

@AaronDJohnson
Copy link
Collaborator

Removing the dependency on timing packages would really help M* Mac installation. Enterprise is pure Python, so the only thing stopping native installation without --no-deps are the Cython packages.

@AaronDJohnson
Copy link
Collaborator

I think moving to support Python 3.12 should be trivial too, so we might as well get that going.

@vhaasteren
Copy link
Member Author

On my M1 macbook pro, healpy is not a problem. Pip chokes on scikit-sparse and libstempo. Realistically, we don't need either. Sparse matrix operations actually don't help that much either.

@vhaasteren
Copy link
Member Author

vhaasteren commented May 8, 2024

@AaronDJohnson, pip/python allows optional dependencies with extras_require, such as this way:

# Core requirements
requirements = [
    "numpy>=1.16.3",
    "scipy>=1.2.0",
    "ephem>=3.7.6.0",
]

# Optional dependencies
extras_require = {
    'full': [
        "healpy>=1.14.0",
        "scikit-sparse>=0.4.5",
        "pint-pulsar>=0.8.3",
        "libstempo>=2.4.4",
    ]
}

Perhaps healpy, which is less problematic, can be in a separate extra also. Then you can install with either:

pip install enterprise-pulsar

or

pip install enterprise-pulsar[full]

Problem with this is backward compatibility in, say, Dockerfiles, which might not have full selected. But optional dependencies cannot be on by default.

@AaronDJohnson
Copy link
Collaborator

AaronDJohnson commented May 8, 2024

Hopefully they pinned the enterprise version in those old Dockerfiles...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants