New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG? check if illustris masses are properly ordered 1th should be secondary, 0th should primary #42

Open

lzkelley opened this issue Feb 10, 2023 · 1 comment

Member

lzkelley commented Feb 10, 2023

No description provided.

Collaborator

mssiwek commented Jun 14, 2023

A few functions to look out for, where primary and secondary masses may not be identified correctly:

_dadt_dedt() in Sesana_Scattering (however, this will be fixed when merging dev with cbd_torques)
_attenuation_BBR1980
_dadt_dedt() in Dynamical_Friction_NFW(). Check the below lines of code:
# ---- Get effective mass of inspiraling secondary
m2 = mass[:, 1]
mstar_sec = self._mmbulge.mstar_from_mbh(m2, scatter=False)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment