Skip to content
This repository has been archived by the owner on Sep 8, 2020. It is now read-only.

Fail CircleCI builds when files have syntax errors #45

Open
nareddyt opened this issue Mar 30, 2018 · 2 comments
Open

Fail CircleCI builds when files have syntax errors #45

nareddyt opened this issue Mar 30, 2018 · 2 comments
Labels
enhancement New feature or request good first issue Good for beginners

Comments

@nareddyt
Copy link
Owner

nareddyt commented Mar 30, 2018

Fail a CircleCI build when a file has a syntax error. We should check all of the following file types:

  • .js
  • .json
  • .html
  • .css

The most important files to check would be in the /src/ directory. These are the code for the Chrome Extension, and we won't know that it's failing if we were to deploy it to users.

@nareddyt nareddyt added enhancement New feature or request good first issue Good for beginners labels Mar 30, 2018
@LucaBozzetto
Copy link

If I'm not wrong this could be fixed adding a -run command and check that all files provided have the required extension.
If I'm right i can easily modify the config.yml file in order to check the files extension.

@nareddyt
Copy link
Owner Author

nareddyt commented Oct 2, 2018

Hey! Yes, we could check the file extension but that won't tell us if there's a syntax error in the actual file.

For example, json file could be formatted because a contributor accidentally deleted a comma. The circleci build will still pass, but the extension would fail at run-time due to the incorrect JSON.

Based on the file extension, we need some way of checking if the syntax is correct for that file. Does that make sense?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for beginners
Projects
None yet
Development

No branches or pull requests

2 participants