Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard dependency on node-fetch breaks React Native #44

Open
abouthalf opened this issue Jun 10, 2021 · 3 comments
Open

Hard dependency on node-fetch breaks React Native #44

abouthalf opened this issue Jun 10, 2021 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@abouthalf
Copy link

ContentfulClient is written to have a hard-coded fallback to node-fetch:

This breaks react-native builds, failing a brwoserlist requirement. Browserlist is not packaged (for obvious reasons) with Expo or the Metro bundler.

@sdedios
Copy link
Member

sdedios commented Jun 22, 2021

We'll look into this for the current feature release on rate limits (i.e. 1.10.0) and try to remove the dependency if it doesn't break the existing v1 branch.

I'll post an update once I reproduce the issue. Thanks!

@sdedios sdedios self-assigned this Jun 22, 2021
@sdedios sdedios added the bug Something isn't working label Jun 22, 2021
@abouthalf
Copy link
Author

Thanks! Really enjoy this library btw - makes Contentful API very easy to use.

@TooTallNate
Copy link

The node-fetch dependency also cause issues with Vercel Edge Functions. 👍 to remove this dep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants