Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investspec tests are failing #119

Open
emlys opened this issue Mar 7, 2023 · 0 comments · Fixed by #120
Open

investspec tests are failing #119

emlys opened this issue Mar 7, 2023 · 0 comments · Fixed by #120
Labels
bug Something isn't working

Comments

@emlys
Copy link
Member

emlys commented Mar 7, 2023

investspec tests are failing because the output RST does not have the expected structure:

======================================================================
ERROR: test_invest_spec (test.test_investspec.TestInvestSpec)
invest_spec role function should return what sphinx expects.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/emily/invest.users-guide/extensions/investspec/test/test_investspec.py", line 56, in test_invest_spec
    nodes, messages = investspec.invest_spec(
  File "/Users/emily/invest.users-guide/extensions/investspec/investspec.py", line 89, in invest_spec
    return parse_rst(rst), []
  File "/Users/emily/invest.users-guide/extensions/investspec/investspec.py", line 33, in parse_rst
    return list(first_node.findall(descend=False, siblings=True))
AttributeError: 'target' object has no attribute 'findall'

======================================================================
ERROR: test_parse_rst (test.test_investspec.TestInvestSpec)
parse_rst should create a correct list of docutils nodes.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/emily/invest.users-guide/extensions/investspec/test/test_investspec.py", line 29, in test_parse_rst
    nodes = investspec.parse_rst(
  File "/Users/emily/invest.users-guide/extensions/investspec/investspec.py", line 33, in parse_rst
    return list(first_node.findall(descend=False, siblings=True))
AttributeError: 'paragraph' object has no attribute 'findall'

This does not seem related to recent changes, I can reproduce it locally with the 3.12.1 version of the invest.users-guide and invest. There have not been any recent releases of sphinx or docutils either.

@emlys emlys added the bug Something isn't working label Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant