Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple sources of truth for base LULC raster path #122

Open
davemfish opened this issue Nov 8, 2023 · 3 comments
Open

multiple sources of truth for base LULC raster path #122

davemfish opened this issue Nov 8, 2023 · 3 comments
Labels
backend Mainly a backend issue / task wontfix This will not be worked on

Comments

@davemfish
Copy link
Contributor

The SQL app hardcodes a default database value for the source LULC raster path:

server\sql_app/models.py:    lulc_url_base = Column(String, default="NLCD_2016_epsg3857.tif")

It would be nice to have a single source of truth for this file on the backend. Or at least a single source within sql_app/. But I'm also not sure why we want a default database value defined in this model. I updated the raster being used by the worker, but did not update this default value, and it seemed to have no impact on anything. Should the worker be responsible for populating this database field?

@davemfish davemfish added the backend Mainly a backend issue / task label Nov 8, 2023
@dcdenu4
Copy link
Member

dcdenu4 commented Nov 27, 2023

I believe the reason there is a default here is because it's not an optional field and during the creation process we don't have this input quite yet. So an error gets thrown. So perhaps the thing to do is remove the default value and make this an optional field? In both cases I think it'll end up being updated / overwritten.

There's likely a better workflow for this too but wanted to provide some context from my memory!

@davemfish davemfish added this to the pre-release milestone May 30, 2024
@davemfish
Copy link
Contributor Author

Do this before -- or at least during -- #127

@davemfish davemfish added the on hold There's a reason we're not working on this yet label May 30, 2024
@davemfish davemfish self-assigned this May 30, 2024
@davemfish davemfish added in progress and removed on hold There's a reason we're not working on this yet labels Aug 26, 2024
@davemfish
Copy link
Contributor Author

There are three places that reference the LULC file, the frontend, the backend-worker, and the sql_app.

I'm not sure that it makes sense for these three different components to reference a single source of the truth for the LULC filename because it is conceivable that in production these 3 components of the system will run on separate systems. @dcdenu4 , if you have a good sense of how to easily resolve this issue, feel free. Otherwise I don't think it's necessarily worth figuring out a solution.

@davemfish davemfish removed their assignment Aug 26, 2024
@davemfish davemfish added wontfix This will not be worked on and removed in progress labels Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Mainly a backend issue / task wontfix This will not be worked on
Projects
Status: No status
Development

No branches or pull requests

2 participants