-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3 feature ask for file configuration at opening #9
Merged
nathangavin
merged 17 commits into
main
from
3-feature-ask-for-file-configuration-at-opening
Sep 27, 2024
Merged
3 feature ask for file configuration at opening #9
nathangavin
merged 17 commits into
main
from
3-feature-ask-for-file-configuration-at-opening
Sep 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt for how to approach using new variables to handle editor initialisation
…miters without a provided filename, also extended load_file function to allow to delimiter to be specified
…gs to required app_data and app_state objects
… for which view and controller to use in the main startup function, so that check only happens once
…ction, view is now injected at runtime, reducing duplication
…tch rust best pr actices;
nathangavin
deleted the
3-feature-ask-for-file-configuration-at-opening
branch
September 27, 2024 09:53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented requested feature for being able to provide file configuration options as input args.