Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front-foot install-hooks #119

Open
nathanjmcdougall opened this issue Nov 15, 2024 · 0 comments
Open

Front-foot install-hooks #119

nathanjmcdougall opened this issue Nov 15, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@nathanjmcdougall
Copy link
Owner

Motivation
Came across this project:
https://github.com/tox-dev/pre-commit-uv
(C.f. https://github.com/j178/pre-commit-rs which has somewhat similar objectives)

The benchmarking showed the pre-commit install-hooks command which I wasn't familiar with. This solves a user experience problem where the hooks are installed on the first commit which is exceptionally slow. We are better to front-foot that during installation with usethis.

Apparently, pre-commit install and pre-commit install-hooks can be combined into a single command as pre-commit install --install-hooks. But it might be better to keep the commands separate to give more informative error messages via usethis.

Summary of desired enhancement
Run pre-commit install-hooks when initializing pre-commit via usethis.

@nathanjmcdougall nathanjmcdougall added the enhancement New feature or request label Nov 15, 2024
@nathanjmcdougall nathanjmcdougall self-assigned this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant