Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Binance TradeLite message support #2008

Open
StephenLee2016 opened this issue Oct 17, 2024 · 1 comment
Open

Implement Binance TradeLite message support #2008

StephenLee2016 opened this issue Oct 17, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@StephenLee2016
Copy link

Bug Report

Expected Behavior

Add here...

Actual Behavior

In live trading, there may be instances where trade_lite cannot be parsed. I noticed that previous submissions have added an “TRADE_LITE” enumeration field, but the parsing function was not found.

Steps to Reproduce the Problem

[ERROR] TESTER-001.ExecClient-BINANCE: Error on handling b'{"stream":"jQ5bcqm7L6JDTIdGPx9NlWtxm2mkzRpVftCnxKrq817NEeDDUfdqHrC6vZck7A1w","data":{"e":"TRADE_LITE","E":1727683915920,"T":1727683915920,"s":"ETHUSDT","q":"0.037","p":"2631.90","m":false,"c":"O-20240930-081155-001-000-29","S":"BUY","L":"2631.90","l":"0.037","t":4467432841,"i":8389765739703625592}}'
KeyError(<BinanceFuturesEventType.TRADE_LITE: 'TRADE_LITE'>)
Traceback (most recent call last):
File "/home/nautilus_trader/nautilus_trader/adapters/binance/futures/execution.py", line 277, in _handle_user_ws_message
self._futures_user_ws_handlerswrapper.data.e

Specifications

  • OS platform: Ubuntu
  • Python version: 3.11
  • nautilus_trader version: v1.203.0
@StephenLee2016 StephenLee2016 added the bug Something isn't working label Oct 17, 2024
@cjdsellers cjdsellers changed the title TradeLite event cannot be resolved. TradeLite event cannot be resolved Oct 18, 2024
@cjdsellers cjdsellers self-assigned this Oct 18, 2024
@cjdsellers
Copy link
Member

cjdsellers commented Oct 18, 2024

Hey @StephenLee2016

Thanks for the report!

I've implemented parsing for this message with this commit ac9dffa.
So when this WS message is received it'll be parsed and delivered into this handler. Thats where the support currently ends though, as it needs to be further parsed into a FillReport.

I'm currently lacking the available bandwidth to continue to that.

Converting this ticket from bug to enhancement request to support the TRADE_LITE feature from Binance.
If someone else would like to pick this up then that would be much appreciated 🙏.

For myself, likely to be addressed later when we port this to Rust and implement SBE.

@cjdsellers cjdsellers added enhancement New feature or request and removed bug Something isn't working labels Oct 18, 2024
@cjdsellers cjdsellers removed their assignment Oct 18, 2024
@cjdsellers cjdsellers changed the title TradeLite event cannot be resolved Implement Binance TradeLite message support Oct 18, 2024
@cjdsellers cjdsellers added the good first issue Good for newcomers label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Development

No branches or pull requests

2 participants