IS-2121: Behandle oppgave vurder avslag ved konsumering av arbeidsuforhet-vurdering #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersrognstad
force-pushed
the
IS-2141-behandle-vurder-avslag
branch
from
46793b7 to
f3ede96
Compare
andersrognstad
changed the title
| personIdent = PersonIdent(vurdering.personident), | ||
| type = oppgaveType, | ||
| ) | ||
| if (ubehandledeVurderAvslagOppgaver.size > 1) throw IllegalStateException("Cannot have more than one ubehandlet $oppgaveType oppgave per person") |
There was a problem hiding this comment.
Kanskje det holder å logge dette? (ellers vil jo Kafka-consumeren krasje, ikke sant?)
There was a problem hiding this comment.
Evnt gjøre forEach nedenfor (sånn at vurderingen lukker alle de åpne oppgavene)
There was a problem hiding this comment.
Ja, det er kanskje like greit å bare logge og lukke alle
geir-waagboe
approved these changes
Mar 12, 2024
eirikdahlen
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Konsumerer arbeidsuforhet-vurdering for å behandle oppgave vurder avslag.