-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incompatible with python 3.12 #606
Comments
cloud-volume is still incompatible. See here seung-lab/cloud-volume#606
Hmm, for compresso it seems that I have released wheels. I think you meant that this is fixed by the checkmark? Yes, DracoPy needs a new release. Thanks for reminding me. |
Yes, compresso's fixed, thanks for doing that! |
forgot to mention, new DracoPy was released last week! |
Unfortunately pysimdjson won't install either! Do you have a CI setup where the 3.12 build could be tested? |
It looks like there's a PR for that with a workaround while it waits to be merged: TkTech/pysimdjson#113 I think I need to overhaul the CloudVolume tests. They've only been able to be run locally for a while. |
By these benchmarks, orjson beats pysimdjson by some margin, has wheels up to and including 3.12, and if the wheels don't exist, the build story is "have a rust compiler released in the last year" rather than the nightmare that building C++ packages from source often is. I can put together a github actions workflow if that would be helpful, if the limiting factor is just travis - but if it's about the test configuration itself I won't be of much use. |
We use both orjson and pysimdjson unfortunately... We use orjson for decoding JSON rapidly as a whole, but pysimdjson has special methods for partial decoding that are necessary for managing very large and numerous json files. This is necessary for processing the spatial index, which we use for creating sharded mesh and skeleton types. It saves hours or days of computation. |
It's also worth noting that the decoder amounts to about 5% of the compute time. Most of the time is spent marshaling the decoded objects into python objects in my experience. |
I posted asking the maintainer of pysimdjson to update their repo. In the meantime, there may be a workaround. I haven't quite gotten this to work yet, but looking at the setup.py file, it seems that if you have cython installed and set https://github.com/TkTech/pysimdjson/blob/master/setup.py#L32 |
Looks like py3.12 wheels are available for pysimdjson. https://pypi.org/project/pysimdjson/#files |
Afaik, this problem is solved. |
Some dependencies cannot be installed on python 3.12, mainly because those packages do not list their build-time dependencies. Listing here as I hit them:
skbuild
The text was updated successfully, but these errors were encountered: