Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give preference to English language tags for property labels #95

Open
jvendetti opened this issue Dec 22, 2017 · 1 comment
Open

Give preference to English language tags for property labels #95

jvendetti opened this issue Dec 22, 2017 · 1 comment

Comments

@jvendetti
Copy link
Member

User reported on the mailing list that they submitted the RDAU ontology to BioPortal where some of the ontology property assertions have both Danish ('da') and English ('en') entries for the rdfs:label property. Screen shot of one such property in Protege:

screenshot 2017-12-22 11 22 19

The first instance of rdfs:label is being chosen as the property label, which results in the BioPortal user interface showing a property list in mixed languages:

screenshot 2017-12-22 11 24 45

... i.e., for this ontology, any property that has a Danish language tag ends up getting displayed in Danish instead of English, since the code doesn't look for / give preference to the English language tags.

The same problem was reported and fixed for the display of the preferred name for ontology classes. Details are still available in the old BMIR JIRA issue tracker (NCBO-1662).

@jvendetti jvendetti added the bug label Dec 22, 2017
@jonquet
Copy link

jonquet commented Dec 22, 2017

We worked on this on the SIFR BioPortal and AgroPortal with @vemonet last May/June.
------ Vincent said:
Now we give a list of languages ​​accepted by the portal ["fr", "en"] for example.

  • For the prefLabel field, we first take a label in one of these languages, otherwise we take the label where the language is not defined. And if there is any, we take what we find (in this case it is a problem of construction of the ontology I think),

  • For synonym fields, definition: we only take values ​​that are either of one of the accepted languages ​​or not of a defined language (we can have several values, not have to limit to one)

  • When indexing: we only index the values ​​that are accepted in synonyms, prefLabel (thus not the values in other languages ​ than those given). But values ​​that are in other languages ​​are indexed with properties. So we can search in by adding also_search_properties = true to the REST call

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants