Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use dockerised and dedicated ontologies_api instance for unit testing #23

Open
alexskr opened this issue Jan 13, 2023 · 2 comments
Open
Assignees

Comments

@alexskr
Copy link
Member

alexskr commented Jan 13, 2023

Currently, we are using production Bioportal api for unit testing of ontologies_api_ruby_client which limits the kind of unit tests we can safely run. Instead of this we should spin up a dockerized and dedicated ontologies_api for unit testing.

@alexskr alexskr self-assigned this Jan 13, 2023
@alexskr
Copy link
Member Author

alexskr commented Jan 18, 2023

unit tests expect to have a few things already to be present on the API side, things like BRO ontology, category, at lest two ontology starting with letter 'c' so my question is should we pre-create those before unit tests kick off or perhaps have ruby_client create them as a part of the unit test run?

@syphax-bouazzouni
Copy link

syphax-bouazzouni commented Jan 18, 2023

I think that ruby_client will create them before the corresponding test as needed. Like what was done in the backend tests, e.g https://github.com/ncbo/ontologies_linked_data/blob/master/test/util/test_notifications.rb#L8-L10

And an empty dockerized ontologies_api would be also easier and faster to use in future UI tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants