Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS: "Management Events Logging Disabled" misses the mark #1668

Open
rdegraaf-ncc3 opened this issue Aug 29, 2024 · 0 comments
Open

AWS: "Management Events Logging Disabled" misses the mark #1668

rdegraaf-ncc3 opened this issue Aug 29, 2024 · 0 comments
Labels
bug Something isn't working potential Unconfirmed issue

Comments

@rdegraaf-ncc3
Copy link
Contributor

rdegraaf-ncc3 commented Aug 29, 2024

Describe the bug

The finding "Management Events Logging Disabled" flags any CloudTrail Trails that do not have management event logging enabled. That's not a very useful thing to check: it's perfectly valid to have multiple Trails in a region and there's no need to log management events in more than one of them. A better thing to check would be for regions that don't have at least one Trail that logs management events.

Note that management events can be split into read and write; we need to make sure that both are covered. There are also settings to exclude "KMS events" and "RDS Data API events"; we also need to make sure that at least one Trail has those disabled. So the check can't be as simple as "ensure that at least one Trail has management event logging enabled"; we need to make sure that at least one Trail in the region has each of the following:

  • management events + read + not(exclude KMS)
  • management events + read + not(exclude RDS)
  • management events + write + not(exclude KMS)
  • management events + write + not(exclude RDS)
@rdegraaf-ncc3 rdegraaf-ncc3 added bug Something isn't working potential Unconfirmed issue labels Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working potential Unconfirmed issue
Projects
None yet
Development

No branches or pull requests

1 participant