Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: automatic rate-limiting #1669

Open
rdegraaf-ncc3 opened this issue Sep 19, 2024 · 1 comment
Open

Feature request: automatic rate-limiting #1669

rdegraaf-ncc3 opened this issue Sep 19, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@rdegraaf-ncc3
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Sometimes ScoutSuite sends too many requests to AWS and they start rate-limiting us:

2024-09-19 11:21:59 LT12115 scout[1334] ERROR emr.py L22: Failed to describe EMR cluster: An error occurred 
(ThrottlingException) when calling the DescribeCluster operation (reached max retries: 4): Rate exceeded

It appears that ScoutSuite reacts with a generic failure handler and retries the request immediately, which just makes the problem worse.

Describe the solution you'd like

ScoutSuite should detect rate-limit errors and automatically adjust its request rate accordingly.

Describe alternatives you've considered

ScoutSuite does have command-line options to limit request rates: https://github.com/nccgroup/ScoutSuite/wiki/Handling-Rate-Limiting. However, using them requires the user to cancel the scan and re-run it, making some guess at appropriate request rates. Since ScoutSuite reports success even if there were errors such as this, it's easy for users to miss the errors, think that they had a complete scan, and miss important issues.

@rdegraaf-ncc3 rdegraaf-ncc3 added the enhancement New feature or request label Sep 19, 2024
@x64-latacora
Copy link

Incremental backoff was implemented but it looks like this 3fe5cde change turned it off?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants