Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use html5 template tag instead of script/div hack #71

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

charlie-hadden
Copy link

I ran into this issue on a project I'm currently working on when using ckeditor in a nested field.

This PR gets rid of the script/div hack in favour of HTML5's <template> tag. This works well for us as we don't need to target IE, but I'm not sure how suitable you'd find it for merging upstream. The browser support isn't too great: http://caniuse.com/#feat=template

That said, there are numerous polyfills that could be used alongside the changes here. The only thing I'd be concerned about with those is whether they block execution of any <script> tags inside the <template>. I've not had chance to test this out yet. Perhaps it would make sense to add an option to nested_fields_for to opt-in to <template>?

Also had a quick look through the open issues, and I believe it would also fix #63.

@ncri
Copy link
Owner

ncri commented Jul 16, 2016

Thanks for this! I will give it a try and test it a bit when I have some time. I won't merge it with master yet because of the lack of support in IE, but we could maintain a separate branch. Or maybe better, make this optional. If you'd make using a template tag optional and use the old hackish way by default I could merge this straight away. We could have an option like use_template_tag for the nested_fields_for call and add a note about it in the readme.

dankimio added a commit to dankimio/nested_form_fields that referenced this pull request Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Templates break when nesting inside a regular Rails fields_for
2 participants