Use html5 template tag instead of script/div hack #71
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this issue on a project I'm currently working on when using ckeditor in a nested field.
This PR gets rid of the script/div hack in favour of HTML5's
<template>
tag. This works well for us as we don't need to target IE, but I'm not sure how suitable you'd find it for merging upstream. The browser support isn't too great: http://caniuse.com/#feat=templateThat said, there are numerous polyfills that could be used alongside the changes here. The only thing I'd be concerned about with those is whether they block execution of any
<script>
tags inside the<template>
. I've not had chance to test this out yet. Perhaps it would make sense to add an option tonested_fields_for
to opt-in to<template>
?Also had a quick look through the open issues, and I believe it would also fix #63.