Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming of hints #1571

Merged
merged 5 commits into from
Aug 26, 2024
Merged

Naming of hints #1571

merged 5 commits into from
Aug 26, 2024

Conversation

jvoigtlaender
Copy link
Contributor

Suggested various renamings of hints, in ways I would consider more useful/consistent in communicating with students in particular.

The changes are distributed over several smaller commits "grouping" similar suggestions, and with brief justifications in the commit messages. To enable cherry-picking of individual suggestions/commits if need be.

- for example, `uncurry (curry f) -> f` mentioned only redundancy of uncurry

- and `pure x *> y -> y` mentioned redundancy of pure, while `x <* pure y -> x` mentions redundancy of <*
- in accordance with `map f (map g x) -> map (f . g) x` being named "Use map once"
- e.g., in `maybe False (x ==) -> (Just x ==)` it seems more useful to mention disappearence of maybe instead of appearance of Just
- e.g., in `any f (concat x) -> any (any f) x` the default name is "Use any" which is strange since any is already used before applying the hint as well
- because corresponding hints for flip/flip, not/not, negate/negate are also not called "Avoid flip" etc. but rather "Redundant flip" ...
@ndmitchell ndmitchell merged commit 5ea729b into ndmitchell:master Aug 26, 2024
0 of 5 checks passed
ndmitchell added a commit that referenced this pull request Aug 26, 2024
Summary:

Test Plan:
@ndmitchell
Copy link
Owner

Thanks - they all look improvements to me. Great to see the incremental improvements.

@jvoigtlaender jvoigtlaender deleted the naming-of-hints branch August 26, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants