Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI displays FT deposits even if "ft_fransfer" fails #733

Open
chloethedev opened this issue Feb 28, 2022 · 0 comments
Open

UI displays FT deposits even if "ft_fransfer" fails #733

chloethedev opened this issue Feb 28, 2022 · 0 comments

Comments

@chloethedev
Copy link

Describe the bug
When FTs are transferred to a DAO address, the Astro UI displays those tokens as entering the DAO treasury. This deposit is displayed even if no tokens are actually sent and there is an error in the transfer.

To Reproduce
Steps to reproduce the behaviour:

  1. send tokens to DAO address with a balance that the sending account does not have (https://explorer.mainnet.near.org/transactions/61492HeieM6xMQu92p2krgh4qjfCdoK4NXoA5MabptjX)
    Screen Shot 2022-02-28 at 12 44 11 PM

  2. Check the DAO treasury on Astro DAO for the FT that was sent and the UI will display the FT as successfully deposited even though the tx failed on-chain.
    Screen Shot 2022-02-28 at 12 10 56 PM

Expected behaviour
If a ft_transfer fails, UI should either:

  1. show failed FT tx
  2. not display the FT tx at all (could be used to spam?)

Additional context
https://t.me/astro_near/4168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant