doc: make doc examples testable in ci #326
Open
+1,103
−1,014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dj8yfo
force-pushed
the
testable_docs_of_derive_macros
branch
from
8a33f86 to
865fe12
Compare
added 8 commits
December 28, 2024 22:21
dj8yfo
commented
Dec 28, 2024
Comment on lines
+297
to
+310
| pub fn add_definitions_recursively<K: BorshSchema, V: BorshSchema>( | ||
| definitions: &mut BTreeMap<Declaration, Definition>, | ||
| ) { | ||
| let definition = Definition::Sequence { | ||
| elements: <(K, V)>::declaration(), | ||
| length_width: Definition::DEFAULT_LENGTH_WIDTH, | ||
| length_range: Definition::DEFAULT_LENGTH_RANGE, | ||
| }; | ||
| let no_recursion_flag = definitions.get(&declaration::<K, V>()).is_none(); | ||
| schema::add_definition(declaration::<K, V>(), definition, definitions); | ||
| if no_recursion_flag { | ||
| <(K, V)>::add_definitions_recursively(definitions); | ||
| } | ||
| } |
There was a problem hiding this comment.
this api was actually out of date
dj8yfo
force-pushed
the
testable_docs_of_derive_macros
branch
from
da1d6fc to
ba3b63a
Compare
|
@race-of-sloths include |
|
@dj8yfo Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: waiting for scoringWe're waiting for maintainer to score this pull request with What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #325
the meaningful part of changes are in commits named
doc: replace ignore -> rust whereever possibleand the like