Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate instance types for GCP #2730

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

blakerosenthal
Copy link
Contributor

Reference Issues or PRs

Closes #2718

Adds back the instances(region:str) function to the GCP provider and validates available instances against the nebari config.

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

Check out and install this branch, then follow the instructions to deploy nebari on GCP. Run nebari validate -c nebari-config.yaml to validate available instance types.

Any other comments?

@blakerosenthal
Copy link
Contributor Author

@marcelovilla It looks like I'm missing a GOOGLE_CREDENTIALS environment variable in the tests. I spent some time with the test code trying to understand this but there's a lot of things that are instantiated at runtime. Is it obvious to you what's failing here?

https://github.com/nebari-dev/nebari/actions/runs/10948510295/job/30399687802?pr=2730

@marcelovilla
Copy link
Member

@blakerosenthal I'll take a look at this tomorrow! Thanks for working on this 🚀

Copy link
Contributor

@dcmcand dcmcand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blakerosenthal can you please add a pytest mock to the fixture at

for google_cloud.instances to allow the unit tests to pass without needing to hit the actual gcp endpoints?

@dcmcand
Copy link
Contributor

dcmcand commented Nov 15, 2024

@blakerosenthal if you have a moment, can you update the tests for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Changes requested 🧱
Development

Successfully merging this pull request may close these issues.

[ENH] - Validate instance types for Google Cloud
3 participants