-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate instance types for GCP #2730
base: main
Are you sure you want to change the base?
Validate instance types for GCP #2730
Conversation
1474aa9
to
bcca516
Compare
@marcelovilla It looks like I'm missing a https://github.com/nebari-dev/nebari/actions/runs/10948510295/job/30399687802?pr=2730 |
@blakerosenthal I'll take a look at this tomorrow! Thanks for working on this 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blakerosenthal can you please add a pytest mock to the fixture at
nebari/tests/tests_unit/conftest.py
Line 92 in 215bbd6
], |
google_cloud.instances
to allow the unit tests to pass without needing to hit the actual gcp endpoints?
@blakerosenthal if you have a moment, can you update the tests for this? |
Reference Issues or PRs
Closes #2718
Adds back the
instances(region:str)
function to the GCP provider and validates available instances against the nebari config.What does this implement/fix?
Put a
x
in the boxes that applyTesting
How to test this PR?
Check out and install this branch, then follow the instructions to deploy nebari on GCP. Run
nebari validate -c nebari-config.yaml
to validate available instance types.Any other comments?