Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directive names are so general (without prefix) and can cause naming collisions #21

Open
amidudu opened this issue Oct 24, 2017 · 1 comment

Comments

@amidudu
Copy link

amidudu commented Oct 24, 2017

The name of directives like next/prev/pagination... are very very common, 3rd parties should prefix the directives so names will be unique

@auban
Copy link
Contributor

auban commented Dec 15, 2017

Hello,

I have those problem when a use with angular foundation the directive pagination create multi directive compilation error.

Is it possible to add prefix like ui-select.

Example:

<ui-swiper>
  <ui-swiper-slides>
    <ui-swiper-slide>Slide1</ui-swiper-slide>
    <ui-swiper-slide>Slide2</ui-swiper-slide>
  </ui-swiper-slides>
  <ui-swiper-prev></ui-swiper-prev>
  <ui-swiper-next></ui-swiper-next>
  <ui-swiper-pagination></ui-swiper-pagination>
</ui-swiper>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants