fix edge case in block concatenation #92
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an error happening when merging transitive edges. This was due to the following edge-case:
b1
andb2
.b1
has an insertion at the end of the block, at positionL1
b2
has an insertion at the beginning of the block, at position0
b1+b2
there will be two insertions at positionL1
, the boundary between the two original blocks. And there is an ambiguity on which one to apply first.To fix this at the moment of merging the two sets of insertions, if two have the same position I join them in a single insertion, appending the second one to the first one.