Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

determine role of WDS in development pipeline #9

Closed
weswalla opened this issue Jan 27, 2023 · 4 comments · May be fixed by #23
Closed

determine role of WDS in development pipeline #9

weswalla opened this issue Jan 27, 2023 · 4 comments · May be fixed by #23

Comments

@weswalla
Copy link
Collaborator

If we are going to modify our development pipeline to remove wds from the picture, then we should make that decision carefully and clean up after ourselves.

Are we sure? Granted, the build pipeline differences have been problematic. WDS does however make claims about its superior speed, we might be slowing things down dramatically by switching to Rollup. But maybe that is fine in the interests of "get it working" and we can revisit WDS later if we start getting reports about slow build speed?
Something else to check: removing WDS means removing the ability to debug in any context other than a Tauri window, which means foregoing Firefox Devtools features and other development tooling plugins. The only way to debug elsewhere is via WDS or similar.
#7 (comment)

Thinking about it more and bypassing WDS may also mean breaking HMR which is really going to slow down development a lot; would you mind testing with your working app to see if you can successfully hot-swap a component? If that's not working then I think we should put some time into getting WDS working again and run hc launch pointed at a URL rather than a file so that a HMR-capable dev env can run through it.
#7 (comment)

@pospi
Copy link
Collaborator

pospi commented Jan 30, 2023

FWIW my rebuild time is just over 10 seconds with a one-component app, so I think we better revisit this soon 😬

@pospi
Copy link
Collaborator

pospi commented Mar 3, 2023

Well, I made some good progress on this today but got stuck on some buggy support between Rollup & Web Dev Server. I can see why this was all wired up in the less-than-optimal way that it was...

modernweb-dev/web#1700 (comment) is exactly what I'm encountering.
Possibly related to open-wc/open-wc#2504; and to rollup/rollup#3642 when using older versions.

Looks like the fix may be coming in the next release modernweb-dev/web@2619968 so will park this until that happens.

@pospi
Copy link
Collaborator

pospi commented Mar 3, 2023

It is worth noting that this is caused by the extremely-old package tweetnacl being referenced in the Holochain launcher. I don't know if a more modern repackaging of that library (eg. tweetnacl-ts) might fix things, but could be worth considering swapping it out.

@pospi
Copy link
Collaborator

pospi commented Jun 17, 2023

Role determined: none. We are phasing this out in favour of a Vite-based build pipeline.

@pospi pospi closed this as completed Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants