Add retryOnFailure option
#112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
|
Thanks for this feature @thgeorgiou - very useful. I will add this to the 4.11 release together with how to use the option in the README. Glad you like Slurm-Mail :-) |
|
Version 4.11 released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I made a small change to allow the administrator to control if whether they want to try sending a mail if there is a failure.
In my case, sometimes my users either miss-typed their emails, or they copied the job template that had an example/invalid address. This caused files to remain in
/var/spool/slurm-mailforever and the program would retry sending every minute, eventually getting my cluster banned from the mail server. SettingretryOnFailureto 0 always deletes the mail files after an attempted send.I am catching all smtplib exceptions
(SMTPHeloError, SMTPRecipientsRefused, SMTPSenderRefused, SMTPNotSupportedError)but perhapsSMTPHeloErrorshouldn't be caught, since it most probably represents a connection error rather than an invalid recipient.Thank you for your work on this very useful tool!