Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use JsonWebKey directly #81

Merged
merged 5 commits into from
Oct 25, 2023
Merged

Use JsonWebKey directly #81

merged 5 commits into from
Oct 25, 2023

Conversation

byrman
Copy link
Contributor

@byrman byrman commented Oct 20, 2023 •
edited
Loading

This deprecation warning shows up a lot in Lizard log files:

/srv/nxt.lizard.net/.venv/lib/python3.8/site-packages/authlib/jose/jwk.py:6: AuthlibDeprecationWarning: Please use ``JsonWebKey`` directly.
  deprecate('Please use ``JsonWebKey`` directly.')

Note that I did not exactly implement jwk.dumps, because I believe we should always find_by_kid: https://github.com/lepture/authlib/blob/master/authlib/jose/jwk.py

@byrman byrman requested a review from caspervdw October 20, 2023 14:22
caspervdw
caspervdw approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@caspervdw caspervdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@byrman byrman merged commit 0e2a1e7 into master Oct 25, 2023
4 checks passed
@byrman byrman deleted the byrman_jsonwebkey branch October 25, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caspervdw caspervdw caspervdw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byrman @caspervdw