Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WSO2OAuthClient #84

Merged
merged 8 commits into from
Feb 19, 2024
Merged

Add WSO2OAuthClient #84

merged 8 commits into from
Feb 19, 2024

Conversation

caspervdw
Copy link
Contributor

No description provided.

@caspervdw caspervdw changed the title WIP WSO2 Add WSO2OAuthClient Feb 15, 2024
@caspervdw caspervdw requested a review from reinout February 15, 2024 14:46
Copy link
Member

@reinout reinout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paar losse opmerkingen, ziet er verder prima uit.

README.rst Outdated Show resolved Hide resolved
nens_auth_client/cognito.py Show resolved Hide resolved
@@ -148,3 +148,24 @@ def load_key(header, payload):

claims.validate(leeway=leeway)
return claims

@staticmethod
def extract_provider_name(claims):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hier ook maar een type hint bij?

Hm, dan moeten we ook even kijken of hier Optional gebruikt moet worden of dat str | None al mag qua python versie.

nens_auth_client/oauth.py Show resolved Hide resolved
nens_auth_client/testsettings.py Show resolved Hide resolved
nens_auth_client/users.py Outdated Show resolved Hide resolved
@caspervdw caspervdw merged commit 8f0714a into master Feb 19, 2024
@caspervdw caspervdw deleted the casper-wso2 branch February 19, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants