Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neo-VM migration checklist #2972

Closed
5 tasks done
lock9 opened this issue Nov 16, 2023 · 2 comments
Closed
5 tasks done

Neo-VM migration checklist #2972

lock9 opened this issue Nov 16, 2023 · 2 comments
Labels
Discussion Initial issue state - proposed but not yet accepted

Comments

@lock9
Copy link
Contributor

lock9 commented Nov 16, 2023

Summary or problem description
The initiative to unify our repositories is underway, starting with the Neo-VM. We've encountered a range of unpredicted challenges during this process. This issue was created to facilitate the planning of the migration, since there are multiple tasks to be done, on different stages.

Do you have any solution you want to propose?
We need to break down the migration into smaller issues, so it can be discussed properly.

Step 1: Initial migration (files)

Step 2: Improvements

Removed from scope:

Neo Version

  • Neo 3

Where in the software does this update applies to?

  • VM
@lock9 lock9 added the Discussion Initial issue state - proposed but not yet accepted label Nov 16, 2023
@cschuchardt88
Copy link
Member

cschuchardt88 commented Nov 16, 2023

Update the build workflow to support the Neo-VM project

This maybe already done for us.

Uses solution file in repo

run: |
dotnet pack -o out -c Release
dotnet nuget push out/*.nupkg -s https://api.nuget.org/v3/index.json -k ${NUGET_TOKEN}

dotnet test /p:CollectCoverage=true /p:CoverletOutputFormat=lcov /p:CoverletOutput=${GITHUB_WORKSPACE}/coverage/lcov

@lock9
Copy link
Contributor Author

lock9 commented Nov 16, 2023

This maybe already done for us.

Yes, I've double-checked and the tests are being run correctly.

@lock9 lock9 closed this as completed Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Initial issue state - proposed but not yet accepted
Projects
None yet
Development

No branches or pull requests

2 participants