[neox] Merge neo-project/neox to neo-project/master #1793
Conversation
| { | ||
| Version = StateRoot.CurrentVersion, | ||
| Index = Block.Index - 1, | ||
| RootHash = Blockchain.Singleton.GetLocalStateRoot(Block.Index - 1) |
There was a problem hiding this comment.
If we don't have the state synchronized , what's happend? we should not be able to be a CN, isn't it?
There was a problem hiding this comment.
I think it doesn't matter.
Because all consensus nodes vote for their calculated StateRoot. As long as the node block synchronization is completed, it has the ability to verify StateRoot, regardless of whether the State Root synchronization is completed. Even if the StateRoot is not synchronized, its StateRoot may be correct. If the StateRoot is incorrect, it will be rejected by other nodes.
* don't use snapshot directly in plugin * persistence and ut * fix mpt * precommit * fix commit * rm LocalRootHashIndex * fix ut * pre commit * fix clone view * change name * rename * abstract * comment * fix ReadOnlyView * rm precommit * rm HashState * add MPTDataCache * optimze * optimize * remove blank line * StateRoot verify fee * expose Root in MPTDataCache * fix some and ut * merge master * master * fix mpt ut * fix Storages and name * rename * add comment * proof prefix * fix * format * format * format * add StateRoot ut * reset mpt prefix * rm GetMessage * throw exception when no script hash in state root * UpdateLocalStateRoot when Storages changed * rename Co-authored-by: Tommo-L <[email protected]>
* don't use snapshot directly in plugin * recover * consensus state root * fix build error * rename * remerge * rm GetMessage * rename * throw exception when no script hash in state root * Clean double enter * Clean big line * format * put root sig into request and response * update consensus ut * Check Json.Serialize map keys (neo-project#1705) * don't use snapshot directly in plugin * recover * consensus state root * fix build error * rename * remerge * rm GetMessage * rename * throw exception when no script hash in state root * Clean double enter * Clean big line * format * put root sig into request and response * update consensus ut * fix some * fix some * format * comment * fix * requst in recovery * StateRootSignature fixed size * no need ？ * format * Update ConsensusContext.cs * Check sc.Complete Co-authored-by: Shargon <[email protected]>
* network * format * add GetStateRootPayload * recover ping * rm state height in Update * get state root of Blockchain.Height - 1 * rm Blockchain.State.cs
* cn state root verify and persist * check state root cache * remove mpt proof, move to plugin * TryAdd optimization * fix * .. * file name * filename * fix error Co-authored-by: Shargon <[email protected]>
|
I will reopen this after disk usage optimization applied on neox. Referring #1876 |
|
I reopen this. I will open another pr to optimize disk usage after this. |
|
I have an idea. Can we decouple StateRoot from the consensus algorithm? We can add a new role to the chain, the status verifier. They are designated by the committee, communicate through additional channels, sign StateRoot and broadcast. |
What's the problem you think we have in current design exchanging signature in |
It's not just reasonable, it's absolutely necessary for consensus nodes to be in agreement wrt current state because it directly affects transaction validation and execution. And #1526 is still relevant, it'd be nice to discuss any changes to the current scheme there. |
|
Since we have new discussion about how to sign |
|
Close this. Move to neo-modules. |
neo-project/neoxcommits to latestneo-project/masterto replace [neox] Merge neox to master #1786MPT Integration Specification
introduction
As we have already merged
MPTinto neo, now it's time for us to integrate it with neo. In this article, I will clarify the detail of the solution inneox.persistence
Using
DataCacheimplemented byMPT, we can replace theStoragein snapshot as the contracts' storage.SnapshotView
consensus
Validators confirm state root of a block in next consensus.
Primary node proposal
PrepareRequestwith signature of previous block state root. Backup nodes verify the state root signature with their local state root and send their signatures inPrepareResponseif succeed.As long as a validator collects
Mpreparation messages, it can generate state root of last block.Because state root is a determined value, validators just vote for right or not. Therefore validators can determine state root in one consensus turn.
PrepareRequest
PrepareResponse
network
State root defination and
GetStateRootmessage for state root sync.StateRoot
GetStateRoot
ledger
When receiving the block, the node will calculate state root after the persist is completed, and it will check the state root cache for state root of the block that have been confirmed by the validators.
When receiving state root signed by validators, the node will check and verify it and compare it with local state root, update state height if they are equal.
@erikzhang @shargon @vncoelho