Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inner class AT application #14

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

embeddedt
Copy link
Member

Previously the InnerClassAccessTransformer was having no effect due to a mismatch in the naming convention (ASM used /, our name was stored as a .).

Added a test case to prevent this from regressing in the future.

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Nov 23, 2024

  • Publish PR to GitHub Packages

Last commit published: 0e20ad8a056b2cfe3e8b096ca355c236d7b9112b.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #14' // https://github.com/neoforged/AccessTransformers/pull/14
        url 'https://prmaven.neoforged.net/AccessTransformers/pr14'
        content {
            includeModule('net.neoforged.accesstransformers', 'at-modlauncher')
            includeModule('net.neoforged.accesstransformers', 'at-cli')
            includeModule('net.neoforged', 'accesstransformers')
            includeModule('net.neoforged.accesstransformers', 'at-parser')
        }
    }
}

Copy link
Member

@sciwhiz12 sciwhiz12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test confirms it works.

@sciwhiz12 sciwhiz12 added the bug Something isn't working label Nov 23, 2024
@sciwhiz12 sciwhiz12 merged commit 90f1408 into neoforged:main Nov 23, 2024
3 checks passed
@neoforged-releases
Copy link

🚀 This PR has been released as AccessTransformers version 11.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants