Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AFTER ordering for dependencies #118

Open
FiniteReality opened this issue Jul 21, 2024 · 0 comments
Open

Use AFTER ordering for dependencies #118

FiniteReality opened this issue Jul 21, 2024 · 0 comments

Comments

@FiniteReality
Copy link
Member

Rationale: most hard dependencies do actually need to be loaded before their dependents.

It's likely the case that mods are copying the MDK's mods.toml and leaving the order as NONE for their dependencies, which can potentially cause crashes with "library mods", as their constructors have not been called before the dependent mods start trying to use them in their mod constructors. We should generally prefer AFTER as it is more likely to be correct for most mods, but keep the comment and explain that NONE should only really be used to avoid circular dependency load order issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant