Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.21.3] Append unknown modded flags to removed_features level data #1703

Open
wants to merge 1 commit into
base: 1.21.x
Choose a base branch
from

Conversation

ApexModder
Copy link
Contributor

@ApexModder ApexModder commented Nov 25, 2024

In vanilla Mojang has data fixers which appends all legacy/removed feature flags to a list (removed_features) in the level data, allowing crash reports to be aware of which flags were active and have since been removed.

This PR implements a simple hook to append unknown modded flags to this list, allowing modders to know if a crash happened in an environment where their alpha testing was once enabled.

An example crash report can be found here, take note of the Removed feature flags: entry, which lists all our test flags.

@ApexModder ApexModder added the 1.21.3 Targeted at Minecraft 1.21.3 label Nov 25, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Nov 25, 2024

  • Publish PR to GitHub Packages

Last commit published: 3bb85857dddd441356f4b453557f84c54f76dc04.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1703' // https://github.com/neoforged/NeoForge/pull/1703
        url 'https://prmaven.neoforged.net/NeoForge/pr1703'
        content {
            includeModule('net.neoforged', 'testframework')
            includeModule('net.neoforged', 'neoforge')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1703.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1703
cd NeoForge-pr1703
curl -L https://prmaven.neoforged.net/NeoForge/pr1703/net/neoforged/neoforge/21.3.42-beta-pr-1703-pr-removed-flags/mdk-pr1703.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.3 Targeted at Minecraft 1.21.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant