Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide demo timer when debug overlay is open #865

Merged

Conversation

sciwhiz12
Copy link
Member

This PR fixes #863 by hiding the demo timer (on the player HUD) when the (F3) debug overlay is visible, to avoid overlap between the demo timer and the debug overlay.

The demo timer is visible as the first line on the right side of the debug overlay (as added by #357), so the information is always available to the user.

The demo timer is visible as the first line on the right side of the
debug overlay, so the information is always available to the user.

Fixes neoforged#863
@sciwhiz12 sciwhiz12 added bug A bug or error rendering Related to rendering regression Worked previously but doesn't anymore 1.20.5 Targeted at Minecraft 1.20.5 labels Apr 26, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Apr 26, 2024

  • Publish PR to GitHub Packages

Last commit published: b7a11d51da21841f832fc74c0edb3c60b0224573.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #865' // https://github.com/neoforged/NeoForge/pull/865
        url 'https://prmaven.neoforged.net/NeoForge/pr865'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr865.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr865
cd NeoForge-pr865
curl -L https://prmaven.neoforged.net/NeoForge/pr865/net/neoforged/neoforge/20.5.9-beta-pr-865-1.20-GH-863-demo-timer-debug-overlap/mdk-pr865.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

embeddedt
embeddedt previously approved these changes Apr 26, 2024
@sciwhiz12 sciwhiz12 merged commit 9b08e72 into neoforged:1.20.x Apr 27, 2024
4 checks passed
@sciwhiz12 sciwhiz12 deleted the 1.20/GH-863-demo-timer-debug-overlap branch April 27, 2024 12:55
ApexModder pushed a commit to ApexModder/NeoForge that referenced this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.20.5 Targeted at Minecraft 1.20.5 bug A bug or error regression Worked previously but doesn't anymore rendering Related to rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text in demo mode is not rendered correctly
3 participants