Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrectly named methods for adding multiple values to RunSourceSets #202

Open
XFactHD opened this issue Jun 7, 2024 · 0 comments
Open

Comments

@XFactHD
Copy link
Member

XFactHD commented Jun 7, 2024

The methods for adding multiple source sets via var-arg or Iterable to a RunSourceSets are incorrectly called add() instead of addAll(). This causes a regression from previous versions where the modSources property was a ListProperty.

/**
* Adds multiple source sets to this run
* The group id used is derived from the project id of the source set if it is not set.
*
* @param sourceSets The source sets to add
*/
void add(Iterable<? extends SourceSet> sourceSets);
/**
* Adds multiple source sets to this run
* The group id used is derived from the project id of the source set if it is not set.
*
* @param sourceSets The source sets to add
*/
void add(SourceSet... sourceSets);

/**
* Adds multiple source sets to this run
*
* @param groupId The group ID of the source sets
* @param sourceSets The source sets to add
*/
void add(String groupId, Iterable<? extends SourceSet> sourceSets);
/**
* Adds multiple source sets to this run
*
* @param groupId The group ID of the source sets
* @param sourceSets The source sets to add
*/
void add(String groupId, SourceSet... sourceSets);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant