From c7dee65a63f5f8c04dbe1df4902db58aaec26602 Mon Sep 17 00:00:00 2001 From: Em Sharnoff Date: Fri, 13 Dec 2024 10:44:26 -0800 Subject: [PATCH] tmp: Ignore filter denial in method failure metrics --- pkg/plugin/framework_methods.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pkg/plugin/framework_methods.go b/pkg/plugin/framework_methods.go index 283a55d79..c67605fa4 100644 --- a/pkg/plugin/framework_methods.go +++ b/pkg/plugin/framework_methods.go @@ -96,7 +96,8 @@ func (m frameworkMetrics) incMethodCall(method string, pod *corev1.Pod, ignored } func (m frameworkMetrics) incFailIfnotSuccess(method string, pod *corev1.Pod, ignored bool, status *framework.Status) { - if status.IsSuccess() { + // it's normal for Filter to return Unschedulable, because that's its way of filtering out pods. + if status.IsSuccess() || (method == "Filter" && status.Code() == framework.Unschedulable) { return }