Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean shutdown on exit #12

Closed
3 tasks
sharnoff opened this issue Jan 11, 2023 · 1 comment
Closed
3 tasks

Clean shutdown on exit #12

sharnoff opened this issue Jan 11, 2023 · 1 comment

Comments

@sharnoff
Copy link
Member

See #8 (comment).

There's a few pieces to this (beyond what's in #8). Probably best to split them into separate PRs.

  • Cleanup on VM informant exit
    • note: Currently (2023-01-10), NeonVM doesn't support clean shutdown, so this is not immediately applicable
  • Cleanup on autoscaler-agent exit (e.g., using pod lifecycle hooks + cancelling top-level context)
  • Cleanup on scheduler exit
    • Some investigation is required here. The scheduler framework knows when it's being replaced, even without any pod lifecycle hooks. However, the pod stays alive until the eviction timeout is reached.
@sharnoff
Copy link
Member Author

This was marked as done on 2023-07-12, but not actually closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant