Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: stop treating downscale denies as an error #926

Closed
Omrigan opened this issue May 6, 2024 · 0 comments · Fixed by #927
Closed

Bug: stop treating downscale denies as an error #926

Omrigan opened this issue May 6, 2024 · 0 comments · Fixed by #927
Assignees
@Omrigan
Labels
t/bug Issue Type: Bug

Comments

@Omrigan
Copy link
Contributor

Omrigan commented May 6, 2024

Follow-up to #770

Environment

Steps to reproduce

Expected result

Actual result

Other logs, links

  • ...
@Omrigan Omrigan added the t/bug Issue Type: Bug label May 6, 2024
@Omrigan Omrigan self-assigned this May 6, 2024
@stradig stradig mentioned this issue May 6, 2024
Closed
Omrigan added a commit that referenced this issue May 6, 2024
@Omrigan
agent: don't treat downscale denies as failed request
4be8583 
Fixes #926, a follow-up for the #770.

The defintion for the VM stuckness was changed to include
denied downscale request in the following commit:

    commit fdf0133
    Author: Shayan Hosseini <[email protected]>
    Date:   Sat Apr 6 09:25:01 2024 -0400

    agent: track more liveness in vm-stuck metrics (#855)

This resulted in the consistent firing of the alert.

We should actually treat the denied downscale as part of the normal
operation.

Signed-off-by: Oleg Vasilev <[email protected]>
@Omrigan Omrigan mentioned this issue May 6, 2024
Merged
Omrigan added a commit that referenced this issue May 7, 2024
@Omrigan
agent: don't treat downscale denies as failed request (#927)
669bb52 
Fixes #926, a follow-up for the #770.

The defintion for the VM stuckness was changed to include denied
downscale request in the following commit:

    commit fdf0133
    Author: Shayan Hosseini <[email protected]>
    Date:   Sat Apr 6 09:25:01 2024 -0400

    agent: track more liveness in vm-stuck metrics (#855)

This resulted in the consistent firing of the alert.

We should actually treat the denied downscale as part of the normal
operation. This can happen due to mismatching policy of what is an
acceptable level memory usage in autoscaler-agent vs vm_monitor.

Signed-off-by: Oleg Vasilev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Omrigan Omrigan

Labels
t/bug Issue Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

agent: don't treat downscale denies as failed request neondatabase/autoscaling
1 participant
@Omrigan