From 42719c3436666f582fafe5acef0f2c5d427ef0e4 Mon Sep 17 00:00:00 2001 From: Em Sharnoff Date: Fri, 24 May 2024 06:56:34 -0700 Subject: [PATCH 1/2] lint/codespell: Fix '*.patch' usage I couldn't get it to reference cluster-autoscaler/ca.patch directly before; turns out it just needs to be prefixed with './' to work correctly. Removing the glob is more precise. --- .github/workflows/lint.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 7ce71db56..d597e6bc9 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -78,7 +78,7 @@ jobs: - uses: codespell-project/actions-codespell@94259cd8be02ad2903ba34a22d9c13de21a74461 # v2.0 with: check_hidden: true - skip: go.sum,*.patch # '*.patch' references cluster-autoscaler/ca.patch, but somehow skipping directly doesn't work... + skip: go.sum,./cluster-autoscaler/ca.patch actionlint: runs-on: ubuntu-latest From 2fbba925ecf4dd5632068ab80d30567fae028c13 Mon Sep 17 00:00:00 2001 From: Em Sharnoff Date: Fri, 24 May 2024 06:58:24 -0700 Subject: [PATCH 2/2] Make codespell happy (typos, exclude list) This commit fixes a couple typos, and also adds 'NotIn' to codespell's exclude list. For some reason, codespell recently started noticing these without any workflow updates. See e.g.: * https://github.com/neondatabase/autoscaling/actions/runs/9223395913/job/25376518993?pr=944 * https://github.com/neondatabase/autoscaling/actions/runs/9218422507/job/25361935678?pr=936 --- .github/workflows/lint.yml | 1 + cluster-autoscaler/Dockerfile | 2 +- neonvm/migration.md | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index d597e6bc9..ace60b6fa 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -78,6 +78,7 @@ jobs: - uses: codespell-project/actions-codespell@94259cd8be02ad2903ba34a22d9c13de21a74461 # v2.0 with: check_hidden: true + ignore_words_list: NotIn # k8s match selectors; codespell tries to correct it to 'noting', 'not in', or 'notion' skip: go.sum,./cluster-autoscaler/ca.patch actionlint: diff --git a/cluster-autoscaler/Dockerfile b/cluster-autoscaler/Dockerfile index 619170346..9fff70207 100644 --- a/cluster-autoscaler/Dockerfile +++ b/cluster-autoscaler/Dockerfile @@ -6,7 +6,7 @@ WORKDIR /workspace ARG CA_GIT_TAG -# Download the repo. It's... quite large, but thankfuly this should get cached +# Download the repo. It's... quite large, but thankfully this should get cached RUN git clone --depth=1 -b $CA_GIT_TAG https://github.com/kubernetes/autoscaler # Only ADD the patch after downloading, to avoid wrecking the cache diff --git a/neonvm/migration.md b/neonvm/migration.md index 86a59ce0f..6d9ae8dd0 100644 --- a/neonvm/migration.md +++ b/neonvm/migration.md @@ -69,7 +69,7 @@ status: ### Questions -- how generate name for target VM (name prefix/sufix/other) ? +- how generate name for target VM (name prefix/suffix/other) ? - how long migration resource should be available (`kubectl get neonvmmigrate`) after migration finished ? - how to cancel migration ? as variant - just delete it (`kubectl delete neonvmmigrate example`) - should migration controller delete source VM after migration ?