Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Warn if a blob in an image is larger than 256 MiB (#7852)
We'd like to get some bits reserved in the length field of image layers for future usage (compression). This PR bases on the assumption that we don't have any blobs that require more than 28 bits (3 bytes + 4 bits) to store the length, but as a preparation, before erroring, we want to first emit warnings as if the assumption is wrong, such warnings are less disruptive than errors. A metric would be even less disruptive (log messages are more slow, if we have a LOT of such large blobs then it would take a lot of time to print them). At the same time, likely such 256 MiB blobs will occupy an entire layer file, as they are larger than our target size. For layer files we already log something, so there shouldn't be a large increase in overhead. Part of #5431
- Loading branch information
d5d15eb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3196 tests run: 3055 passed, 1 failed, 140 skipped (full report)
Failures on Postgres 14
test_basebackup_with_high_slru_count[github-actions-selfhosted-sequential-10-13-30]
: releaseFlaky tests (1)
Postgres 16
test_vm_bit_clear_on_heap_lock
: debugCode coverage* (full report)
functions
:31.4% (6449 of 20544 functions)
lines
:48.3% (49861 of 103277 lines)
* collected from Rust tests only
d5d15eb at 2024-05-23T13:55:27.541Z :recycle: