Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_timeline_archival_chaos hits log error #10070

Open
jcsp opened this issue Dec 10, 2024 · 1 comment · May be fixed by #10150
Open

test_timeline_archival_chaos hits log error #10070

jcsp opened this issue Dec 10, 2024 · 1 comment · May be fixed by #10150
Assignees
@arpad-m

Comments

@jcsp
Copy link
Collaborator

jcsp commented Dec 10, 2024

https://neon-github-public-dev.s3.amazonaws.com/reports/pr-9978/12240079195/index.html#testresult/314b8921da5c5a9/retries

First log error on pageserver_2: (1603, '2024-12-09T17:12:30.404054Z  WARN request{method=PUT path=/v1/tenant/dc41c9c7a8d2d4046d786f9e05a86d1e/location_config request_id=ee51f4e1-5bc3-4f62-be8c-b0f0ecedcea1}:upsert_location{tenant_id=dc41c9c7a8d2d4046d786f9e05a86d1e shard_id=0000}: offloaded timeline dd17b03eb917223858a7dfcd5dd0cc68 was dropped without having cleaned it up at the ancestor\n')
Hint: use scripts/check_allowed_errors.sh to test any new allowed_error you add
@arpad-m
Copy link
Member

arpad-m commented Dec 13, 2024 •
edited
Loading

Problem

Looking at the logs, this seems to be offload_timeline racing with Tenant::shutdown, in this case, with upsert_location during an Attached->Secondary transition.

  • A : compaction task decides to offload timeline
  • B: tenant shutdown is called
  • B: tenant defuses for drop all of the offloaded timelines
  • B waits for timeline shutdowns to complete
  • A: compaction task removes the timeline from timelines and adds offloaded timeline to tenant. finishes with the offload.
  • B finished waiting, drops the Tenant object

The issue is that we add the offloaded timeline to the tenant after the defuse_for_drop loop of shutdown has already ran.

Solution

See #10150

@arpad-m arpad-m linked a pull request Dec 13, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arpad-m arpad-m

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix defusing race between Tenant::shutdown and offload_timeline neondatabase/neon
2 participants
@jcsp @arpad-m