Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic: Consume posthog API from storage controller and pageserver #10187

Open
jcsp opened this issue Dec 18, 2024 · 0 comments
Open

Epic: Consume posthog API from storage controller and pageserver #10187

jcsp opened this issue Dec 18, 2024 · 0 comments
Labels
c/storage/controller Component: Storage Controller c/storage/pageserver Component: storage: pageserver

Comments

@jcsp
Copy link
Collaborator

jcsp commented Dec 18, 2024

Posthog is a system for managing feature flags, amongst other things.

Currently when we do a "feature flag" for a storage feature, it's really a configuration attribute on either PageserverConf or TenantConf. These are cumbersome to manage, as they're really intended more for long term configurable things than for lots of turnover in settings coming and going. They're also cumbersome to change, as they can only be toggled during deploys.

An API like Posthog's is appropriate for relatively rare operations, where the cost of checking flags is not too high -- for example compaction, serving a basebackup. It is not appropriate for checking on very frequent operations, such as getpage requests. Any featured flagged behavior during getpage requests would need to be loaded earlier, for example during tenant attach.

@jcsp jcsp added c/storage/controller Component: Storage Controller c/storage/pageserver Component: storage: pageserver labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/storage/controller Component: Storage Controller c/storage/pageserver Component: storage: pageserver
Projects
None yet
Development

No branches or pull requests

1 participant