Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage_sync2: downloads should cancel in response to task_mgr shutdown #2996

Closed
problame opened this issue Dec 2, 2022 · 1 comment
Closed

storage_sync2: downloads should cancel in response to task_mgr shutdown #2996

problame opened this issue Dec 2, 2022 · 1 comment
Assignees
@problame
Labels
t/bug Issue Type: Bug

Comments

@problame
Copy link
Contributor

problame commented Dec 2, 2022

The storage_sync2 download functions are not responsive to task_mgr::shutdown.

So, if a download is slow, it will prevent pageserver from being shut down, or, as of #2977 , prevent a tenant from being /:tenant_id/forgetten.

When fixing this, probably through cancel-by-drop, make sure that the storage_sync2 metrics associated with download are still correctly accounted.
@problame problame added the t/bug Issue Type: Bug label Dec 2, 2022
problame added a commit that referenced this issue Dec 2, 2022
@problame
test_ignore_while_attaching: it's kinda broken, add XXX pointing to #…
75d0dde 
…2996
@SomeoneToIgnore SomeoneToIgnore mentioned this issue Dec 20, 2022
Merged
@jcsp
Copy link
Collaborator

jcsp commented Jan 5, 2024

We have cancellation for remote operations now (#6097 and #6096)

@jcsp jcsp closed this as completed Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@problame problame

Labels
t/bug Issue Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jcsp @problame @SomeoneToIgnore