Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename EphmeralFile::size to EphemeralFile::len #5034

Closed
problame opened this issue Aug 18, 2023 · 1 comment · Fixed by #5076
Closed

rename EphmeralFile::size to EphemeralFile::len #5034

problame opened this issue Aug 18, 2023 · 1 comment · Fixed by #5076
Labels
c/storage/pageserver Component: storage: pageserver m/good_first_issue Moment: when doing your first Neon contributions

Comments

@problame
Copy link
Contributor

Originally posted by @koivunej in #4994 (comment)
@problame problame added c/storage/pageserver Component: storage: pageserver m/good_first_issue Moment: when doing your first Neon contributions labels Aug 18, 2023
@problame problame mentioned this issue Aug 18, 2023
Merged
@Reminiscent
Copy link
Contributor

Hi, I'd like to try this issue.

@Reminiscent Reminiscent mentioned this issue Aug 23, 2023
Merged
5 tasks
arpad-m pushed a commit that referenced this issue Aug 24, 2023
@Reminiscent
rename EphmeralFile::size to EphemeralFile::len (#5076)
fa74d56 
## Problem
close #5034

## Summary of changes
Based on the
[comment](#4994 (comment)).
Just rename the `EphmeralFile::size` to `EphemeralFile::len`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c/storage/pageserver Component: storage: pageserver m/good_first_issue Moment: when doing your first Neon contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rename EphmeralFile::size to EphemeralFile::len Reminiscent/neon
3 participants
@problame @koivunej @Reminiscent