remove sync walredo impl & clean up production ansible #7753
Assignees
Comments
problame
added a commit
that referenced
this issue
May 14, 2024
refs #7753 This PR is step (1) of removing sync walredo from Pageserver. Changes: * Remove the sync impl * If sync is configured, warn! and use async instead * Remove the metric that exposes `kind` * Remove the tenant status API that exposes `kind` Future Work ----------- After we've released this change to prod and are sure we won't roll back, we will 1. update the prod Ansible to remove the config flag from the prod pageserver.toml. 2. remove the remaining `kind` code in pageserver These two changes need no release inbetween. See #7753 for details.
problame
added a commit
that referenced
this issue
May 15, 2024
refs #7753 This PR is step (1) of removing sync walredo from Pageserver. Changes: * Remove the sync impl * If sync is configured, warn! and use async instead * Remove the metric that exposes `kind` * Remove the tenant status API that exposes `kind` Future Work ----------- After we've released this change to prod and are sure we won't roll back, we will 1. update the prod Ansible to remove the config flag from the prod pageserver.toml. 2. remove the remaining `kind` code in pageserver These two changes need no release inbetween. See #7753 for details.
a-masterov
pushed a commit
that referenced
this issue
May 20, 2024
refs #7753 This PR is step (1) of removing sync walredo from Pageserver. Changes: * Remove the sync impl * If sync is configured, warn! and use async instead * Remove the metric that exposes `kind` * Remove the tenant status API that exposes `kind` Future Work ----------- After we've released this change to prod and are sure we won't roll back, we will 1. update the prod Ansible to remove the config flag from the prod pageserver.toml. 2. remove the remaining `kind` code in pageserver These two changes need no release inbetween. See #7753 for details.
problame
added a commit
that referenced
this issue
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
(1) rip out sync impl, make config setting still accepted but a no-op, warn if config setting is != async
(2) release, make sure we won't roll back
(3) remove the field from production pageserver.toml (Ansible change)
(4) remove config flag parsing code
(5) release; if we have to roll back PS version, the field will not be in PS toml; that's fine cuz (1) changed the default to async
Impl
The text was updated successfully, but these errors were encountered: