Instability in test_prefetch
#9961
Assignees
Labels
a/test
Area: related to testing
Comments
github-merge-queue bot
pushed a commit
that referenced
this issue
Dec 10, 2024
## Problem See #9961 Current implementation of prefetch buffer resize doesn't correctly handle in-flight requests ## Summary of changes 1. Fix index of entry we should wait for if new prefetch buffer size is smaller than number of in-flight requests. 2. Correctly set flush position Co-authored-by: Konstantin Knizhnik <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this issue
Dec 13, 2024
## Problem `test_prefetch` is flaky (#9961), but if it passes, the run time is less than 30 seconds — we don't need an extended timeout for it. ## Summary of changes - Remove extended test timeout for `test_prefetch`
|
Seems to be stable after the fix 
Discussed with @hlinnaka and @knizhnik, it's needed for correctness test at this moment. Making it less heavy will decrease the chance that it will catch the actual problem Considering that and that it's not flaky atm, closing. Feel free to reopen if you still see a problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Test was added in https://github.com/neondatabase/neon/pull/9847/files
Is failing with a timeout, about 10% of the time.
The test does a tight loop of reads for many minutes: should this be in
test_runner/performanceinstead? Even if we adjust the timeout on this test, I worry that a test like this will destabilize others when run in parallel.The text was updated successfully, but these errors were encountered: