Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable jemalloc for benchmarks and tests #9963

Open
erikgrinaker opened this issue Dec 2, 2024 · 0 comments
Open

Enable jemalloc for benchmarks and tests #9963

erikgrinaker opened this issue Dec 2, 2024 · 0 comments
Assignees
Labels
a/benchmark Area: related to benchmarking a/tech_debt Area: related to tech debt c/storage Component: storage

Comments

@erikgrinaker
Copy link
Contributor

Currently, Jemalloc is enabled (for Pageserver, Proxy, and Safekeeper) in the binary (e.g. bin/pageserver.rs), not in the crate itself (i.e. lib.rs). This means that benchmarks and tests use the standard allocator, which in particular may affect benchmark results.

We should enable Jemalloc crate-wide in lib.rs itself, but only via a feature or cfg attribute that's enabled by the binaries and tests/benchmarks. Otherwise, loading the crate will implicitly enable Jemalloc for crate consumers, and conflict with other crates that also change the allocator.

@erikgrinaker erikgrinaker added a/benchmark Area: related to benchmarking a/tech_debt Area: related to tech debt c/storage Component: storage labels Dec 2, 2024
@erikgrinaker erikgrinaker self-assigned this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/benchmark Area: related to benchmarking a/tech_debt Area: related to tech debt c/storage Component: storage
Projects
None yet
Development

No branches or pull requests

1 participant